linux-kernel - Re: [git pull -tip] headers_check fixes for other architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090206155624.GR18368@elte.hu>
Date:	Fri, 6 Feb 2009 16:56:24 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Tony Luck <tony.luck@...el.com>,
	Sam Ravnborg <sam@...nborg.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	hskinnemoen@...el.com, cooloney@...nel.org, ralf@...ux-mips.org,
	dhowells@...hat.com, matthew@....cx, chris@...kel.net,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git pull -tip] headers_check fixes for other architectures


* Russell King - ARM Linux <linux@....linux.org.uk> wrote:

> Taking this further, if you're including linux/types.h into another
> header file, you're including it because you want some C type from
> that or an included file.  Use of that type is also not ASM friendly,
> so the use is going to have to be excluded by ifndef in that header.

There's a ton of header files that can be included in assembly code and 
which also contain C declarations and definitions. This is achieved by 
adding a:

 #ifndef __ASSEMBLY__
 #endif

Blocks around the C code. Especially for smallish or single-purpose files 
this is often a cleaner method than splitting the file.

There's more than 40 such headers on x86 alone.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/