linux-kernel - Re: [PATCH] [resend] Resume from hibernation fails with pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090206175635.5344ce37@lxorguk.ukuu.org.uk>
Date:	Fri, 6 Feb 2009 17:56:35 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	Ondrej Zary <linux@...nbow-software.org>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [resend] Resume from hibernation fails with pata_it821x
 RAID volume

>     See CodingStyle chapter 8 for the preferred multiline comment style.
> 
> > +		memset(&id[ATA_ID_SERNO], 0x20, ATA_ID_SERNO_LEN);
> 
>     Why not ' '?
> 
> MBR, Sergei


Digging into the docs the RAID serial number (and what that means isn't
defined anywhere I can see) is byte offset 54-73 in each of the 4 128
byte blocks returned by the chip status query we do at boot
(it821x_probe_firmware).

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/