[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200902071330.00779.linux@rainbow-software.org>
Date: Sat, 7 Feb 2009 13:29:58 +0100
From: Ondrej Zary <linux@...nbow-software.org>
To: Alan Cox <alan@...rguk.ukuu.org.uk>
Cc: Sergei Shtylyov <sshtylyov@...mvista.com>,
linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [resend] Resume from hibernation fails with pata_it821x RAID volume
On Friday 06 February 2009 18:56:35 Alan Cox wrote:
> > See CodingStyle chapter 8 for the preferred multiline comment style.
> >
> > > + memset(&id[ATA_ID_SERNO], 0x20, ATA_ID_SERNO_LEN);
> >
> > Why not ' '?
> >
> > MBR, Sergei
>
> Digging into the docs the RAID serial number (and what that means isn't
> defined anywhere I can see) is byte offset 54-73 in each of the 4 128
> byte blocks returned by the chip status query we do at boot
> (it821x_probe_firmware).
Yes, found it there. But it seems to be the same number as present in the
IDENTIFY data. It contains date and time of boot (matches RAID_SERIAL_NUMBER
structure found in iteraid.h in driver source from ITE) instead of date and
time of RAID creation.
--
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists