linux-kernel - Re: [-mm patch] Show memcg information during OOM (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090206022600.GC13655@balbir.in.ibm.com>
Date:	Fri, 6 Feb 2009 07:56:00 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	kamezawa.hiroyu@...fujitsu.com, linux-kernel@...r.kernel.org,
	nishimura@....nes.nec.co.jp, lizf@...fujitsu.com,
	linux-mm@...ck.org
Subject: Re: [-mm patch] Show memcg information during OOM (v3)

* Andrew Morton <akpm@...ux-foundation.org> [2009-02-05 13:55:54]:

> On Tue, 3 Feb 2009 14:46:47 -0800
> Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > > +/**
> > > + * mem_cgroup_print_mem_info: Called from OOM with tasklist_lock held in
> > > + * read mode.
> > > + * @memcg: The memory cgroup that went over limit
> > > + * @p: Task that is going to be killed
> > > + *
> > > + * NOTE: @memcg and @p's mem_cgroup can be different when hierarchy is
> > > + * enabled
> > > + */
> > > +void mem_cgroup_print_oom_info(struct mem_cgroup *memcg, struct task_struct *p)
> > > +{
> > > +	struct cgroup *task_cgrp;
> > > +	struct cgroup *mem_cgrp;
> > > +	/*
> > > +	 * Need a buffer on stack, can't rely on allocations. The code relies
> > > +	 * on the assumption that OOM is serialized for memory controller.
> > > +	 * If this assumption is broken, revisit this code.
> > > +	 */
> > > +	static char task_memcg_name[PATH_MAX];
> > > +	static char memcg_name[PATH_MAX];
> > 
> > I don't think we need both of these.  With a bit of shuffling we could
> > reuse the single buffer?
> 
> ping?
>

We can use a single buffer, I'll post a patch to fix it.
 

-- 
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/