linux-kernel - Re: [PATCH] spi: limit reaches -1, tested 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <498F1979.1030104@gmail.com>
Date:	Sun, 08 Feb 2009 18:42:17 +0100
From:	Mariusz Ceier <mceier@...il.com>
To:	Roel Kluin <roel.kluin@...il.com>
CC:	David Brownell <david-b@...bell.net>,
	spi-devel-general@...ts.sourceforge.net,
	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] spi: limit reaches -1, tested 0

Roel Kluin writes in first post:
> -			while ((read(drv_data) == 0) && limit--);
> +			while ((read(drv_data) == 0) && --limit);

Roel Kluin writes in last post:
> -			while ((read(drv_data) == 0) && limit--);
> +			while ((read(drv_data) == 0) && limit--)
> +				cpu_relax();

so should there be postfix or prefix decrement ? :)

Mariusz Ceier


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/