[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090208220440.55574c7c@mjolnir.drzeus.cx>
Date: Sun, 8 Feb 2009 22:04:40 +0100
From: Pierre Ossman <drzeus@...eus.cx>
To: Anton Vorontsov <avorontsov@...mvista.com>
Cc: Ben Dooks <ben-linux@...ff.org>, Arnd Bergmann <arnd@...db.de>,
Kumar Gala <galak@...nel.crashing.org>,
Liu Dave <DaveLiu@...escale.com>, sdhci-devel@...t.drzeus.cx,
linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH 08/11] sdhci: Add support for hosts that don't specify
clocks in the cap. register
On Fri, 6 Feb 2009 21:06:57 +0300
Anton Vorontsov <avorontsov@...mvista.com> wrote:
> FSL eSDHC hosts don't provide clocks bits in the capabilities register,
> instead we're getting clocks values from the device tree.
>
> There is somewhat similar change[1] from Ben Dooks, the change adds
> callbacks for getting the clocks. But for eSDHC the callbacks are
> superfluous, since the clocks are static.
>
> [1] http://lkml.org/lkml/2008/12/2/157
>
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
> ---
As I told Ben, I prefer if we stick to the standard as much as
possible. So no external info unless the register is set to zero.
And since we know the Samsung chip needs callbacks, we might as well
add them here. It's not like this is a performance critical path.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)
Powered by blists - more mailing lists