linux-kernel - Re: [PATCH] i2c: add missing KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Feb 2009 09:35:37 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Frank Seidel <frank@...eidel.de>, Frank Seidel <fseidel@...e.de>,
	linux kernel <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, ben-linux@...ff.org,
	linux-i2c@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	ukleinek@...ormatik.uni-freiburg.de, Frans Pop <elendil@...net.nl>,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Subject: Re: [PATCH] i2c: add missing KERN_* constants to printks

> I mean the (first) printk in the loop, not the last printk in this
> function. So what I am suggesting is:
> 
> +	printk(KERN_DEBUG);
> 	for (i = 0; i < i2c->irqlogidx; i++)
> 		printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
> 	printk("\n");

Hmm, I was told (by Jean ;)) that every printk should end with newline,
otherwise it might get interrupted with other output -> mess.

Bye,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)