linux-kernel - Re: [PATCH] i2c: add missing KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090209112718.5ddf68db@hyperion.delvare>
Date:	Mon, 9 Feb 2009 11:27:18 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	Frank Seidel <frank@...eidel.de>, Frank Seidel <fseidel@...e.de>,
	linux kernel <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, ben-linux@...ff.org,
	linux-i2c@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	ukleinek@...ormatik.uni-freiburg.de, Frans Pop <elendil@...net.nl>,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Subject: Re: [PATCH] i2c: add missing KERN_* constants to printks

On Mon, 9 Feb 2009 09:35:37 +0100, Wolfram Sang wrote:
> > I mean the (first) printk in the loop, not the last printk in this
> > function. So what I am suggesting is:
> > 
> > +	printk(KERN_DEBUG);
> > 	for (i = 0; i < i2c->irqlogidx; i++)
> > 		printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
> > 	printk("\n");
> 
> Hmm, I was told (by Jean ;)) that every printk should end with newline,
> otherwise it might get interrupted with other output -> mess.

Correct, however the code was already wrong before Frank's patch, and
his patch is fixing a different problem. So I don't have any problem
with this, this can be fixed in a later patch if anybody cares.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/