linux-kernel - Re: [PATCH] tracing/function-graph-tracer: handle the leaf functions from trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090209113748.GD18757@elte.hu>
Date:	Mon, 9 Feb 2009 12:37:48 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/function-graph-tracer: handle the leaf
	functions from trace_pipe


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> When one cat on the trace file, the leaf functions are printed without brackets:
> 
> function();
> 
> whereas in the trace_pipe file we'll see the following:
> 
> function() {
> }
> 
> This is because the ring_buffer handling is not the same between those two files.
> On the trace file, when an entry is printed, the iterator advanced and then we can
> check the next entry.
> 
> There is no iterator with trace_pipe, the current entry to print has been peeked
> and not consumed. So checking the next entry will still return the current one while
> we don't consume it.
> 
> This patch introduces a new value for the output callbacks to ask the tracing
> core to not consume the current entry after printing it.
> We need it because we will have to consume the current entry ourself to check the next one.
> 
> Now the trace_pipe is able to handle well the leaf functions.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> ---
>  kernel/trace/trace.c                 |    4 +-
>  kernel/trace/trace.h                 |    7 +++--
>  kernel/trace/trace_functions_graph.c |   48 +++++++++++++++++++++------------
>  3 files changed, 36 insertions(+), 23 deletions(-)

Applied to tip/tracing/ftrace, thanks Frederic!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/