linux-kernel - Re: ima changes to shmem breaks !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0902091351p4a719809gf1f2119735f0430f@mail.gmail.com>
Date:	Mon, 9 Feb 2009 16:51:31 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	James Morris <jmorris@...ei.org>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Serge Hallyn <serue@...ibm.com>
Subject: Re: ima changes to shmem breaks !CONFIG_SHMEM

On Mon, Feb 9, 2009 at 16:49, Randy Dunlap wrote:
> Mike Frysinger wrote:
>> On Mon, Feb 9, 2009 at 16:23, James Morris wrote:
>>> On Mon, 9 Feb 2009, Mike Frysinger wrote:
>>>> commit 1df9f0a73178718969ae47d813b8e7aab2cf073c broke default building
>>>> for Blackfin systems:
>>>>   CC      mm/shmem.o
>>>> mm/shmem.c: In function 'shmem_zero_setup':
>>>> mm/shmem.c:2670: error: implicit declaration of function 'ima_shm_check'
>>>> make[1]: *** [mm/shmem.o] Error 1
>>>>
>>>> that's because the ima.h include was added behind the CONFIG_SHMEM
>>>> markings rather than everywhere, just like the function is used.
>>> Does this seem like the correct fix?
>>
>> it converts the build error to a build warning:
>>   CC      mm/shmem.o
>> In file included from mm/shmem.c:32:
>> include/linux/ima.h:25: warning: 'struct linux_binprm' declared inside
>> parameter list
>> include/linux/ima.h:25: warning: its scope is only this definition or
>> declaration, which is probably not what you want
>
> Add to the other patch:
>
> --- linux-next-20090209.orig/include/linux/ima.h
> +++ linux-next-20090209/include/linux/ima.h
> @@ -8,6 +8,7 @@
>  */
>
>  #include <linux/fs.h>
> +struct linux_binprm;
>
>  #ifndef _LINUX_IMA_H
>  #define _LINUX_IMA_H
>
>
>
> and it builds for me.

yes, it builds w/out warnings now for me too.  any reason those are
outside of _LINUX_IMA_H ?  looks like they should both be inside of
that.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/