linux-kernel - Re: commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 breaks rlogin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090209055848.GA3889@gondor.apana.org.au>
Date:	Mon, 9 Feb 2009 16:58:48 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Jeff Chua <jeff.chua.linux@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 breaks rlogin

On Fri, Feb 06, 2009 at 07:35:50PM +0800, Jeff Chua wrote:
>
> > Did you change the kernel on the other side during these tests?
> 
> No. Was hoping that the traces would show where it hang for the good
> and bad trace.

Then the problem isn't my patch at all.  My patch only affects
the side sending the urgent data, according to your straces, rlogin
is only receiving urgent data, not sending it.  So the patch cannot
have an affect.

> > If reverting the patch on the other side does fix the problem
> > for you, please do the two straces there.
> 
> Sorry, forgot to send the good trace run for the patched remote side.
> Here's attached. t5.good.

No you're still stracing rlogin, which in this case is the receiver
of the urgent data.  Please strace the sending side, which would be
presumably be rlogind in this case.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/