linux-kernel - Re: [PATCH 2/2] kprobes: check CONFIG_FREEZER instead of CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090210010546.GA28129@elte.hu>
Date:	Tue, 10 Feb 2009 02:05:46 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Len Brown <lenb@...nel.org>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	Pavel Machek <pavel@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Cheng Renquan <crquan@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] kprobes: check CONFIG_FREEZER instead of CONFIG_PM


* Len Brown <lenb@...nel.org> wrote:

> > > Check CONFIG_FREEZER instead of CONFIG_PM because kprobe booster
> > > depends on freeze_processes() and thaw_processes() when CONFIG_PREEMPT=y.
> > > 
> > > This fixes a linkage error which occurs when CONFIG_PREEMPT=y, CONFIG_PM=y
> > > and CONFIG_FREEZER=n.
> > > 
> > > Reported-by: Cheng Renquan <crquan@...il.com>
> > > Signed-off-by: Masami Hiramatsu <mhiramat@...hat.com>
> > > Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> > > ---
> > >  arch/ia64/kernel/kprobes.c |    2 +-
> > >  arch/x86/kernel/kprobes.c  |    2 +-
> > >  kernel/kprobes.c           |    2 +-
> > >  3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > looks good, the x86 bits:
> > 
> > Acked-by: Ingo Molnar <mingo@...e.hu>
> 
> man, we have too many config options:-)

the non-x86 bits (kernel/kprobes.c) are crappy though, and broke -rc4
allnoconfig:

kernel/built-in.o: In function `collect_garbage_slots':
kprobes.c:(.kprobes.text+0x16e4): undefined reference to `freeze_processes'
kprobes.c:(.kprobes.text+0x16f2): undefined reference to `thaw_processes'
kprobes.c:(.kprobes.text+0x176b): undefined reference to `thaw_processes'

Could someone please fix all of this without #ifdefs?

	Ingo

View attachment "config" of type "text/plain" (56459 bytes)