linux-kernel - Re: [PATCH] dmaengine: Fix oops on dmatest module unload.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090212.204840.124087545.nemoto@toshiba-tops.co.jp>
Date:	Thu, 12 Feb 2009 20:48:40 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	thierry.reding@...onic-design.de
Cc:	haavard.skinnemoen@...el.com, linux-kernel@...r.kernel.org,
	dan.j.williams@...el.com
Subject: Re: [PATCH] dmaengine: Fix oops on dmatest module unload.

On Tue, 10 Feb 2009 10:31:03 +0100, Thierry Reding <thierry.reding@...onic-design.de> wrote:
> This patch fixes an oops that happens when the dmatest module is unloaded. The
> dma_release_channel() function is called on channels that have already been
> cleaned up (and therefore freed) with dmatest_cleanup_channel().
...
> @@ -433,10 +433,10 @@ static void __exit dmatest_exit(void)
>  
>  	list_for_each_entry_safe(dtc, _dtc, &dmatest_channels, node) {
>  		list_del(&dtc->node);
> +		dma_release_channel(dtc->chan);
>  		dmatest_cleanup_channel(dtc);
>  		pr_debug("dmatest: dropped channel %s\n",
>  			 dma_chan_name(dtc->chan));
> -		dma_release_channel(dtc->chan);
>  	}
>  }

Good catch!  Please move pr_debug() too.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/