linux-kernel - Re: [PATCHv2 5/5] VFS: DazukoFS, stackable-fs, file access control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1eiy3csjv.fsf@fess.ebiederm.org>
Date:	Thu, 12 Feb 2009 12:24:20 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	John Ogness <dazukocode@...ess.net>
Cc:	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	malware-list@...ts.printk.net, eparis@...hat.com,
	hch@...radead.org, alan@...rguk.ukuu.org.uk
Subject: Re: [PATCHv2 5/5] VFS: DazukoFS, stackable-fs, file access control

John Ogness <dazukocode@...ess.net> writes:

> Patch 5: Creates /dev/dazukofs.ign as an (optional) mechanism for any
>          processes to hide themselves from DazukoFS file access
>          control.

Your reference counting is broken.  What happens if a process exits
and you are ignoring it. 

When fixing this use a struct pid * not struct task_struct *.  That
is what struct pid is for there is no need to pin the entire task
struct into memory after the process exits just because
you decided to ignore it.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/