linux-kernel - Re: [PATCHv2 1/5] VFS: DazukoFS, stackable-fs, file access control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86y6wagmmg.fsf@johno.fn.ogness.net>
Date:	Fri, 13 Feb 2009 20:31:03 +0100
From:	John Ogness <dazukocode@...ess.net>
To:	Jan Engelhardt <jengelh@...ozas.de>
Cc:	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	malware-list@...ts.printk.net, eparis@...hat.com,
	hch@...radead.org, alan@...rguk.ukuu.org.uk
Subject: Re: [PATCHv2 1/5] VFS: DazukoFS, stackable-fs, file access control

On 2009-02-12, Jan Engelhardt <jengelh@...ozas.de> wrote:
>>+DazukoFS is typically mounted on top of an existing directory. For example,
>>+to stack DazukoFS on top of the /opt directory, the following mount(8)
>>+command can be given:
>>+
>>+# mount -t dazukofs /opt /opt
> [...]
>>+# mount -t dazukofs /opt /mnt
>>+
>>+When accessing files within /mnt, you will be accessing files in /opt
>>+(through DazukoFS). When accessing files directly in /opt, DazukoFS will not
>>+be involved.
>>+
>>+THIS HAS POTENTIAL PROBLEMS!
>
> This ought to be done better in light of the problem that one
> could issue `mount -t dazukofs /mnt /opt`
> In kernel code, I'm thinking something like
>
> static int foofs_dothis(...)
> {
> 	buf = call d_path on sb->s_root
> 	call namei_lookup on buf
> 	use lookup's resulting dentry as source directory
> }
>
> This assumes at least that namei_lookup will not return the new SB's
> dentry for the given path.
> Iff that works out somehow, the 'device' part in the mount command
> line is practically ignored like it is for like procfs.

If we want to forbid users from being able to do this, I think it
would be simpler just to fail the mount if it is _not_ specified for
direct stacking. This forces users to use a syntax that makes it very
clear what they are doing.

Since mounting to a different directory could cause problems, I think
it will be good to forbid it. I will make this change for the next
patch series.

John Ogness
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/