linux-kernel - Re: [PATCH] usb: musb: - kill the compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902121230.06353.david-b@pacbell.net>
Date:	Thu, 12 Feb 2009 12:30:06 -0800
From:	David Brownell <david-b@...bell.net>
To:	felipe.balbi@...ia.com
Cc:	Bryan Wu <cooloney@...nel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mike Frysinger <vapier.adi@...il.com>
Subject: Re: [PATCH] usb: musb: - kill the compile warning

On Thursday 12 February 2009, Felipe Balbi wrote:
> On Thu, Feb 12, 2009 at 07:03:25AM +0100, David Brownell wrote:
> > On Friday 06 February 2009, Bryan Wu wrote:
> > > -       return (MUSB_BUSCTL_OFFSET(i, 0) + mbase);
> > > +       return (void __iomem *)(MUSB_BUSCTL_OFFSET(i, 0) + mbase);
> > 
> > Why is MUSB_BUSCTL_OFFSET() returning something other than
> > an integer?  "mbase" is already "void __iomem *", so the only
> > way that should trigger a warning is if that OFFSET() macro
> > is doing something odd.
> 
> The warning only comes on Blackfin's version of this, this hunk is
> unnecessary

We want to get rid of Blackfin-specific warnings too ... but
what I was hinting is that this can't be the right fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/