linux-kernel - Re: [PATCH] Fix vde network backend in user mode linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0902161334250.18110@jikos.suse.cz>
Date:	Mon, 16 Feb 2009 13:38:46 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Luca Bigliardi <shammash@...ha.org>
Cc:	trivial@...nel.org, linux-kernel@...r.kernel.org,
	jdike@...toit.com, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Fix vde network backend in user mode linux


[ doesn't seem to be picked up by anyone into current -next nor -mmotm, 
  but isn't appropriate for trivial; adding akpm to cc ]

On Mon, 2 Feb 2009, Luca Bigliardi wrote:

> * Replace kmalloc() with uml_kmalloc()
>   (fix build failure)
> * Remove unnecessary UM_KERN_INFO in printk()
>   (don't display '<6>' while printing info)
> 
> Signed-off-by: Luca Bigliardi <shammash@...ha.org>
> ---
>  arch/um/drivers/vde_user.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/um/drivers/vde_user.c b/arch/um/drivers/vde_user.c
> index 56533db..c5c4325 100644
> --- a/arch/um/drivers/vde_user.c
> +++ b/arch/um/drivers/vde_user.c
> @@ -78,7 +78,7 @@ void vde_init_libstuff(struct vde_data *vpri, struct vde_init *init)
>  {
>  	struct vde_open_args *args;
>  
> -	vpri->args = kmalloc(sizeof(struct vde_open_args), UM_GFP_KERNEL);
> +	vpri->args = uml_kmalloc(sizeof(struct vde_open_args), UM_GFP_KERNEL);
>  	if (vpri->args == NULL) {
>  		printk(UM_KERN_ERR "vde_init_libstuff - vde_open_args "
>  		       "allocation failed");
> @@ -91,8 +91,8 @@ void vde_init_libstuff(struct vde_data *vpri, struct vde_init *init)
>  	args->group = init->group;
>  	args->mode = init->mode ? init->mode : 0700;
>  
> -	args->port ?  printk(UM_KERN_INFO "port %d", args->port) :
> -		printk(UM_KERN_INFO "undefined port");
> +	args->port ?  printk("port %d", args->port) :
> +		printk("undefined port");
>  }
>  
>  int vde_user_read(void *conn, void *buf, int len)
> -- 
> 1.5.6.5
> 
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/