linux-kernel - Re: [review patch 0/1] add firedtv driver for FireWire-attached DVB receivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090217102951.21dab08c@pedra.chehab.org>
Date:	Tue, 17 Feb 2009 10:29:51 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	linux1394-devel@...ts.sourceforge.net,
	Christian Dolzer <c.dolzer@...ital-everywhere.com>,
	Andreas Monitzer <andy@...itzer.com>,
	Manu Abraham <manu@...uxtv.org>,
	Fabio De Lorenzo <delorenzo.fabio@...il.com>,
	Robert Berger <robert.berger@...iableembeddedsystems.com>,
	Ben Backx <ben@...ckx.com>, Henrik Kurelid <henrik@...elid.se>,
	Rambaldi <Rambaldi@...all.nl>
Subject: Re: [review patch 0/1] add firedtv driver for FireWire-attached DVB
 receivers

On Mon, 16 Feb 2009 20:33:17 +0100 (CET)
Stefan Richter <stefanr@...6.in-berlin.de> wrote:

> firedtv is a driver for FireWire-attached DVB receivers from Digital
> Everywhere GmbH.  The devices are known as FireDTV (external boxes) and
> FloppyDTV (internal cards, also connected through FireWire).  The driver
> supports
>   - the DVB-C, DVB-S/S2, and DVB-T range of FireDTV and FloppyDTV
>     models,
>   - control and reception through Linux' common DVB userspace ABI,
>   - standard definition video reception (MPEG2-TS, to be decoded
>     by userspace client software),
>   - Common Interface for Conditional Access Modules,
>   - input from infrared remote control.
> 
> High definition support has yet to be added.  Also, firedtv still
> requires the ieee1394 kernel API but alternative support of the new
> firewire kernel API is in progress.
> 
> The driver, formerly known as firesat, was originally written by Andreas
> Monitzer.  Manu Abraham, Ben Backx, and Henrik Kurelid updated and
> extended the driver; I did trivial cleanups, refactoring and small
> fixes.
> 
> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>

The driver looks sane to my eyes. I found just one minor issue (see bellow).
Acked-by: Mauro Carvalho Chehab <mchehab@...hat.com>

> +
> +		/*
> +		 * AV/C specs say that answers should be sent within 150 ms.
> +		 * Time out after 200 ms.
> +		 */
> +		if (wait_event_timeout(fdtv->avc_wait,
> +				       fdtv->avc_reply_received,
> +				       HZ / 5) != 0) {

Instead of using HZ, it would be better to use:
	msecs_to_jiffies(200)


Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/