linux-kernel - Re: [review patch 0/1] add firedtv driver for FireWire-attached DVB receivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <499DB5B7.8080802@s5r6.in-berlin.de>
Date:	Thu, 19 Feb 2009 20:40:39 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
CC:	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	linux1394-devel@...ts.sourceforge.net,
	Christian Dolzer <c.dolzer@...ital-everywhere.com>,
	Andreas Monitzer <andy@...itzer.com>,
	Manu Abraham <manu@...uxtv.org>,
	Fabio De Lorenzo <delorenzo.fabio@...il.com>,
	Robert Berger <robert.berger@...iableembeddedsystems.com>,
	Ben Backx <ben@...ckx.com>, Henrik Kurelid <henrik@...elid.se>,
	Rambaldi <Rambaldi@...all.nl>
Subject: Re: [review patch 0/1] add firedtv driver for FireWire-attached DVB
 receivers

Mauro Carvalho Chehab wrote:
> The driver looks sane to my eyes. I found just one minor issue (see bellow).
> Acked-by: Mauro Carvalho Chehab <mchehab@...hat.com>

Thanks for checking.

>> +
>> +		/*
>> +		 * AV/C specs say that answers should be sent within 150 ms.
>> +		 * Time out after 200 ms.
>> +		 */
>> +		if (wait_event_timeout(fdtv->avc_wait,
>> +				       fdtv->avc_reply_received,
>> +				       HZ / 5) != 0) {
> 
> Instead of using HZ, it would be better to use:
> 	msecs_to_jiffies(200)

OK, I switch this.

(Hmm, what if msecs_to_jiffies could be rolled out to a constant
expression if called on a constant argument...?)
-- 
Stefan Richter
-=====-==--= --=- =--==
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/