linux-kernel - Re: [PATCH] cpufreq: Change link order of x86 cpufreq modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090218183137.GD26802@elte.hu>
Date:	Wed, 18 Feb 2009 19:31:37 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	davej@...emonkey.org.uk, linux-kernel@...r.kernel.org,
	cpufreq@...r.kernel.org
Subject: Re: [PATCH] cpufreq: Change link order of x86 cpufreq modules


* Matthew Garrett <mjg59@...f.ucam.org> wrote:

> Change the link order of the cpufreq modules to ensure that they're 
> probed in the preferred order when statically linked in.
>     
> Signed-off-by: Matthew Garrett <mjg@...hat.com>
> 
> diff --git a/arch/x86/kernel/cpu/cpufreq/Makefile b/arch/x86/kernel/cpu/cpufreq/Makefile
> index 560f776..509296d 100644
> --- a/arch/x86/kernel/cpu/cpufreq/Makefile
> +++ b/arch/x86/kernel/cpu/cpufreq/Makefile
> @@ -1,6 +1,11 @@
> +# Link order matters. K8 is preferred to ACPI because of firmware bugs in early
> +# K8 systems. ACPI is preferred to all other hardware-specific drivers.
> +# speedstep-* is preferred over p4-clockmod.

Nice fix! Where does this information come from? Distro module 
ordering magic? It's rather non-trivial.

(small style nit: the first line in the Makefile is overlong.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/