linux-kernel - Re: [s390] next Feb 18: defconfig build break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090219095150.GA5808@flint.arm.linux.org.uk>
Date:	Thu, 19 Feb 2009 09:51:50 +0000
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Mike Frysinger <vapier.adi@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"Sachin P. Sant" <sachinp@...ibm.com>, linux-s390@...r.kernel.org,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com
Subject: Re: [s390] next Feb 18: defconfig build break

On Thu, Feb 19, 2009 at 10:45:25AM +1030, Rusty Russell wrote:
> Subject: arm: allow usage of string functions in linux/string.h
> 
> In introducing a trivial "strstarts()" function in linux/string.h, we
> hit:
> 
> 	arch/arm/boot/compressed/misc.o: In function `strstarts':
> 	misc.c:(.text+0x368): undefined reference to `strlen'
> 	misc.c:(.text+0x378): undefined reference to `strncmp'
> 
> This is because of "CFLAGS_misc.o := -Dstatic=" in the Makefile.
> "static inline strstarts(...)" becomes non-inline, and refers to the
> other string ops.
> 
> The simplest workaround is to include asm/string.h.  This makes sense
> anyway, since lib/string.c won't be linked against this so we can't
> use those functions anyway.
> 
> Compile tested here.
> 
> Reported-by: linux-next
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

Acked-by: Russell King <rmk+kernel@....linux.org.uk>

I guess this should go in with the change which caused the breakage.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/