linux-kernel - Re: [PATCH] sx.c: fix dbl statement if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a63d67fe0902190155x423c517avf369c61bab7376df@mail.gmail.com>
Date:	Thu, 19 Feb 2009 12:55:02 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sx.c: fix dbl statement if - add missing braces

On 2/18/09, Ilpo Järvinen <ilpo.jarvinen@...sinki.fi> wrote:
>
> Caused by 736d54533aed (sx.c: fix missed unlock_kernel()
> on error path in sx_fw_ioctl()). You guys keep breaking
> things this way in every single kernel release in at least
> couple of places... :-(
>

Yep.  Sorry about that.

Signed-off-by: Dan Carpenter <error27@...il.com>

regards,
dan carpenter

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
> Cc: Dan Carpenter <error27@...il.com>
> ---
>  drivers/char/sx.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/sx.c b/drivers/char/sx.c
> index f146e90..d7c4165 100644
> --- a/drivers/char/sx.c
> +++ b/drivers/char/sx.c
> @@ -1746,9 +1746,10 @@ static long sx_fw_ioctl(struct file *filp, unsigned
> int cmd,
>  		sx_dprintk(SX_DEBUG_FIRMWARE, "returning type= %ld\n", rc);
>  		break;
>  	case SXIO_DO_RAMTEST:
> -		if (sx_initialized)	/* Already initialized: better not ramtest the board.
>  */
> +		if (sx_initialized) {	/* Already initialized: better not ramtest the
> board.  */
>  			rc = -EPERM;
>  			break;
> +		}
>  		if (IS_SX_BOARD(board)) {
>  			rc = do_memtest(board, 0, 0x7000);
>  			if (!rc)
> --
> 1.5.2.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/