linux-kernel - Re: [PATCH] fix FREEZE/THAW compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090220095158.GA9587@lst.de>
Date:	Fri, 20 Feb 2009 10:51:58 +0100
From:	Christoph Hellwig <hch@....de>
To:	Takashi Sato <t-sato@...jp.nec.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix FREEZE/THAW compat_ioctl regression

So who's going to send this to Linus?  Having freeze/thaw regressed in
2.6.29 would be very sad for all the xfs users.

On Mon, Feb 16, 2009 at 01:57:25PM +0100, Christoph Hellwig wrote:
> Commit 8e961870bb9804110d5c8211d5d9d500451c4518 removed the FREEZE/THAW
> handling in xfs_compat_ioctl but never added any compat handler back, so
> now any freeze/thaw request from a 32-bit binary ond 64-bit userspace
> will fail.
> 
> As these ioctls are 32/64-bit compatible two simple COMPATIBLE_IOCTL
> entries in fs/compat_ioctl.c will do the job.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> 
> Index: xfs/fs/compat_ioctl.c
> ===================================================================
> --- xfs.orig/fs/compat_ioctl.c	2009-02-16 12:48:23.000000000 +0000
> +++ xfs/fs/compat_ioctl.c	2009-02-16 12:49:34.000000000 +0000
> @@ -1913,6 +1913,9 @@
>  /* 0x00 */
>  COMPATIBLE_IOCTL(FIBMAP)
>  COMPATIBLE_IOCTL(FIGETBSZ)
> +/* 'X' - originally XFS but some now in the VFS */
> +COMPATIBLE_IOCTL(FIFREEZE)
> +COMPATIBLE_IOCTL(FITHAW)
>  /* RAID */
>  COMPATIBLE_IOCTL(RAID_VERSION)
>  COMPATIBLE_IOCTL(GET_ARRAY_INFO)
---end quoted text---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/