linux-kernel - Re: [PATCH] x86: enable x2apic early at the first point

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090220095530.GA15186@elte.hu>
Date:	Fri, 20 Feb 2009 10:55:30 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: enable x2apic early at the first point


* Ingo Molnar <mingo@...e.hu> wrote:

> >  arch/x86/kernel/apic/apic.c           |    3 +--
> >  arch/x86/kernel/apic/x2apic_cluster.c |    5 ++++-
> >  arch/x86/kernel/apic/x2apic_phys.c    |    5 ++++-
> >  arch/x86/kernel/apic/x2apic_uv_x.c    |    4 +++-
> >  drivers/pci/dmar.c                    |    3 ++-
> >  5 files changed, 14 insertions(+), 6 deletions(-)
> 
> I've applied it because it fixes a real bug, but this code 
> really needs a cleanup. Look at the repeat patterns:

unapplied it again as it breaks the build:

arch/x86/kernel/apic/x2apic_cluster.c: In function 'x2apic_acpi_madt_oem_check':
arch/x86/kernel/apic/x2apic_cluster.c:17: error: 'disable_x2apic' undeclared (first use in this function)
arch/x86/kernel/apic/x2apic_cluster.c:17: error: (Each undeclared identifier is reported only once
arch/x86/kernel/apic/x2apic_cluster.c:17: error: for each function it appears in.)

so please resend the fixed and cleaned up version.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/