linux-kernel - Re: [PATCH] Export device_add_attributes() so drivers can use it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40902200728k1466121cqb772bb9e5d1a777c@mail.gmail.com>
Date:	Fri, 20 Feb 2009 08:28:42 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Export device_add_attributes() so drivers can use it.

Hi Kay,

Thanks for the reply, it clarifies a lot.  It sounds like this really
should be documented (in Documentation/driver-model/device.txt?).  I'm
happy to add a blurb to that effect and send a patch, but I want to
make sure I really understand the model before I do so.  I've got a
couple more questions below:

On Thu, Feb 19, 2009 at 4:08 PM, Kay Sievers <kay.sievers@...y.org> wrote:
[...]
> If an attribute is not available at event time, nothing of this can
> ever work. If you look a the device a second later, you will see the
> proper looking files and values, and all the test programs will work,
> but it will always fail at device creation.
[...]
> That all might not be needed for your specific setup/driver/device and
> may work fine for your need. But we don't want to encourage anybody
> with another new API which creates the usual trouble we need to fix
> later.

Fair enough

> And we need to fix things like this all the time.

Can you point me at a 'textbook' example of one of these fixups?

> Also the existing sysfs attribute groups API has the same problem if
> the group is created later, but as far as I can see it should work
> fine for your purpose. So it's better using that, instead of exporting
> another different API.

Okay, I this option looks pretty straight forward too.

Thanks,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/