linux-kernel - Re: [PATCH v2] ext[234]: Return -EIO not -ESTALE on directory traversal through deleted inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e8340490902202335i2b01cd63gd685efeab64ad338@mail.gmail.com>
Date:	Sat, 21 Feb 2009 02:35:02 -0500
From:	Bryan Donlan <bdonlan@...il.com>
To:	Theodore Tso <tytso@....edu>, Bryan Donlan <bdonlan@...il.com>,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	sct@...hat.com, akpm@...ux-foundation.org, adilger@....com
Subject: Re: [PATCH v2] ext[234]: Return -EIO not -ESTALE on directory 
	traversal through deleted inode

On Fri, Feb 20, 2009 at 12:59 PM, Theodore Tso <tytso@....edu> wrote:
> On Fri, Feb 20, 2009 at 12:53:39PM -0500, Bryan Donlan wrote:
>> On Mon, Feb 16, 2009 at 8:10 PM, Bryan Donlan <bdonlan@...il.com> wrote:
>>
>> > +               if (unlikely(IS_ERR(inode))) {
>> > +                       if (PTR_ERR(inode) == -ESTALE) {
>> > +                               ext3_error(dir->i_sb, "ext2_lookup",
>> > +                                               "deleted inode referenced: %lu",
>> > +                                               ino);
>> > +                               return ERR_PTR(-EIO);
>> > +                       } else {
>> > +                               return ERR_CAST(inode);
>> > +                       }
>> > +               }
>>
>> I just noticed that I forgot to edit the function name in the
>> ext3_error and ext4_error invocations... Would it be better to send a
>> delta to fix this or resubmit the whole thing?
>
> It's already been pulled into akpm's tree as separate patches.  I'll
> fix up the ext4 one by hand; probably better for you to send
> replacement patches for ext3 separately to akpm and ask him to replace.
>
> I'd suggest using __FUNC__ instead of hard-coding the function name, BTW...

akpm's already fixed up his copies. Sorry for the inconvenience there
- I made sure to get the printf format specifiers right but on the
other hand completely missed the comparatively obvious function name
:)

Thanks,

Bryan Donlan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/