linux-kernel - Re: [PATCH tj-percpu] percpu: s/size/bytes/g in new percpu allocator and interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <499FB1D8.1090601@kernel.org>
Date:	Sat, 21 Feb 2009 16:48:40 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	rusty@...tcorp.com.au, tglx@...utronix.de, x86@...nel.org,
	linux-kernel@...r.kernel.org, hpa@...or.com, jeremy@...p.org,
	cpw@....com, mingo@...e.hu
Subject: Re: [PATCH tj-percpu] percpu: s/size/bytes/g in new percpu allocator
 and interface

Hello, Andrew.

Tejun Heo wrote:
> Do s/size/bytes/g as per Andrew Morton's suggestion.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> ---
> Okay, here's the patch.  I also merged it to #tj-percpu.  Having done
> the conversion, I'm not too thrilled tho.  size was consistently used
> to represent bytes and it's very customary especially if it's a memory
> allocator and I can't really see how s/size/bytes/g makes things
> better for percpu allocator.  Clear naming is good but not being able
> to use size in favor of bytes seems a bit extreme to me.  After all,
> it's size_t and sizeof() not bytes_t and bytesof().  That said, I have
> nothing against bytes either, so...

Eeeek... I'm sorry but I'm popping this patch.  It just doesn't look
right.  I'll add comments where appropriate that size is in bytes
instead.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/