linux-kernel - Re: Fwd: PCF8583 not detected on RiscPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090222082829.GG16596@n2100.arm.linux.org.uk>
Date:	Sun, 22 Feb 2009 08:28:29 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Alessandro Zummo <alessandro.zummo@...ertech.it>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Juergen Beisert <j.beisert@...gutronix.de>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ben Dooks <ben-linux-arm@...ff.org>,
	linux-kernel@...r.kernel.org
Subject: Re: Fwd: PCF8583 not detected on RiscPC

On Sun, Feb 22, 2009 at 01:19:36AM +0100, Alessandro Zummo wrote:
> On Sat, 21 Feb 2009 20:41:47 +0000
> Russell King - ARM Linux <linux@....linux.org.uk> wrote:
> 
> > Confirmation: reverting 02bb584f3b1cfc8188522a4d2c8881b65073a4f1 and
> > removing the reference to I2C_DRIVERID_PCF8583 results in the regression
> > being fixed and normal behaviour being restored.
> > 
> > Patch below.
> 
>  this is a nack on my side. the whole i2c has been converted to the
>  new style model. everyone is following and this is
>  the wrong way to fix the issue.

While you may not desire the patch, the fact of the matter is that the
conversion caused a regression.  Regressions trump forward progress and
fixing stuff to work on new platforms.

So, really, I'm not listening to NACKs from anyone for this.  The only
thing I'll listen to is something _constructive_ to make it work again.
I'm sure Andrew Morton will back me up on this.

>  the device must be instantiated in the appropriate
>  platform code. 
> 
>  for an example of what needs to be done, you can grep for
>  i2c_board_info in arch/arm .
> 
>  if you need help, just tell me where's the acorn related
>  platform setup code and I'll have a look.

drivers/i2c/busses/i2c-acorn.c

That's where the problem is - it's totally unclear how to convert
this to the board_info method, because it doesn't live in the kernel
as a platform thing.  Putting the board_info stuff into i2c-acorn
just seems completely wrong.

Now, we can either totally reorganize i2c-acorn, but that won't be
acceptable for 2.6.29-rc.

The problem is that this *is* a regression, and therefore must be fixed
in 2.6.29-rc.  As I see it, the only sane way to do that is to revert
the conversion until a proper fix can be done.

So, please provide constructive suggestions on how to add boardinfo to
this in a sane way, or we revert PCF8583 back to something which works.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/