linux-kernel - Re: [patch 1/2] slub: move min_partial to struct kmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0902231119390.22276@qirst.com>
Date:	Mon, 23 Feb 2009 11:20:34 -0500 (EST)
From:	Christoph Lameter <cl@...ux-foundation.org>
To:	David Rientjes <rientjes@...gle.com>
cc:	Pekka Enberg <penberg@...helsinki.fi>, linux-kernel@...r.kernel.org
Subject: Re: [patch 1/2] slub: move min_partial to struct kmem_cach

On Mon, 23 Feb 2009, David Rientjes wrote:

> > Move the ilog2 use into calculate_min_partial()? Otherweise
> > calculate_min_partial is merely enforcing limits and not doing any
> > calculations.
> >
>
> The second patch in this series as a /sys/kernel/slab/cache/min_partial
> tunable that uses calculate_min_partial() to enforce a sane range, so
> while it may not actually be doing any calculations, the ilog2() is
> appropriately placed in kmem_cache_open().  We don't want to be taking the
> log of the user's min_partial value.

Then Rename the function to set_min_partial()?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/