linux-kernel - Re: [TIP] BUG kmalloc-4096: Poison overwritten (ath5k_rx_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090223163032.GA3450@hash.localnet>
Date:	Mon, 23 Feb 2009 11:30:32 -0500
From:	Bob Copeland <me@...copeland.com>
To:	Nick Kossifidis <mickflemm@...il.com>
Cc:	Jiri Slaby <jirislaby@...il.com>,
	Sitsofe Wheeler <sitsofe@...oo.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	ath5k-devel@...ema.h4ckr.net,
	"Luis R. Rodriguez" <lrodriguez@...eros.com>
Subject: Re: [TIP] BUG kmalloc-4096: Poison overwritten (ath5k_rx_skb_alloc)

On Mon, Feb 23, 2009 at 06:27:35PM +0200, Nick Kossifidis wrote:
> 2009/2/23 Bob Copeland <me@...copeland.com>:
> > On Mon, Feb 23, 2009 at 06:15:51PM +0200, Nick Kossifidis wrote:
> >> Typo alert...
> >> rs->rs_more = !!(rx_status->rx_status_0 & AR5K_5212_RX_DESC_STATUS0_MORE);
> >
> > I'm slow... what's wrong with it?
> >
> 
> "!!"
> 
> it should be just
> 
> rs->rs_more = (rx_status->rx_status_0 & AR5K_5212_RX_DESC_STATUS0_MORE);

No, that's intentional.  That was actually a bug we had at some point 
(rs_more is a u8 so the bitwise AND overflowed).  The "!!" makes it zero 
or one so it fits.

-- 
Bob Copeland %% www.bobcopeland.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/