linux-kernel - Re: [PATCH] Remove some pointless conditionals before kfree() in kernel/cgroup.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Feb 2009 22:46:19 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Paul Menage <menage@...gle.com>
cc:	linux-kernel@...r.kernel.org,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Paul Jackson <pj@....com>, Simon Derr <simon.derr@...l.net>
Subject: Re: [PATCH] Remove some pointless conditionals before kfree() in 
 kernel/cgroup.c

On Mon, 23 Feb 2009, Paul Menage wrote:

> On Sun, Feb 22, 2009 at 2:05 PM, Jesper Juhl <jj@...osbits.net> wrote:
> > Hi,
> >
> > Here's a small patch for kernel/cgroup.c
> >
> > Removes a few pointless tests of pointer == 0 before kfree() in
> > kernel/cgroup.c.
> > If the pointer we hand to kfree() is 0, then kfree() is a noop, so there
> > is no need to test.
> >
> > Reduces object file size a bit :
> >
> > Before:
> > $ size kernel/cgroup.o
> >   text    data     bss     dec     hex filename
> >  21593    7804    4924   34321    8611 kernel/cgroup.o
> > After:
> > $ size kernel/cgroup.o
> >   text    data     bss     dec     hex filename
> >  21537    7744    4924   34205    859d kernel/cgroup.o
> 
> Thanks. I'm a bit surprised that it also shrunk the data segment size
> (and in fact, by more than the text segment size). Any idea how that
> came about?
> 
Can't say I've got a good explanation for that, no.

-- 
Jesper Juhl <jj@...osbits.net>             http://www.chaosbits.net/
Plain text mails only, please      http://www.expita.com/nomime.html
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/