linux-kernel - Re: [PATCH] Remove some pointless conditionals before kfree() in kernel/cgroup.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49A25F30.9060305@cn.fujitsu.com>
Date:	Mon, 23 Feb 2009 16:32:48 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Jesper Juhl <jj@...osbits.net>
CC:	linux-kernel@...r.kernel.org,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Paul Jackson <pj@....com>, Simon Derr <simon.derr@...l.net>,
	Paul Menage <menage@...gle.com>
Subject: Re: [PATCH] Remove some pointless conditionals before kfree() in
 kernel/cgroup.c

Jesper Juhl wrote:
> Hi,
> 
> Here's a small patch for kernel/cgroup.c
> 
> Removes a few pointless tests of pointer == 0 before kfree() in 
> kernel/cgroup.c.
> If the pointer we hand to kfree() is 0, then kfree() is a noop, so there 
> is no need to test.
> 
> Reduces object file size a bit : 
> 
> Before:
> $ size kernel/cgroup.o
>    text    data     bss     dec     hex filename
>   21593    7804    4924   34321    8611 kernel/cgroup.o
> After:
> $ size kernel/cgroup.o
>    text    data     bss     dec     hex filename
>   21537    7744    4924   34205    859d kernel/cgroup.o
> 
> and source file size shrinks a bit too - always nice.
> 
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Reviewed-by: Li Zefan <lizf@...fujitsu.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/