linux-kernel - Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16693.1235565430@redhat.com>
Date:	Wed, 25 Feb 2009 12:37:10 +0000
From:	David Howells <dhowells@...hat.com>
To:	Justin Chen <jchen@...st41.cup.hp.com>
Cc:	dhowells@...hat.com, linux-arch@...r.kernel.org,
	bjorn.helgaas@...com, justin.chen@...com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv]

Justin Chen <jchen@...st41.cup.hp.com> wrote:

> Change the index to unsigned long in all bitops for [frv]
> 
> Signed-off-by: Justin Chen <justin.chen@...com>
> Reviewed-by: Bjorn Helgaas <bjorn.helgaas@...com>

Mostly okay, apart from:

> -static inline int __constant_test_bit(int nr, const volatile void * addr)
> +static inline int
> +__constant_test_bit(unsigned long nr, const volatile void *addr)

Please move the return type onto the next line also.  Other than that:

Acked-by: David Howells <dhowells@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/