linux-kernel - Re: [PATCH 4/4] keys: make procfiles per-user-namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090225210336.GA20086@us.ibm.com>
Date:	Wed, 25 Feb 2009 15:03:36 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	David Howells <dhowells@...hat.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Linux Containers <containers@...ts.osdl.org>
Subject: Re: [PATCH 4/4] keys: make procfiles per-user-namespace

Quoting David Howells (dhowells@...hat.com):
> Serge E. Hallyn <serue@...ibm.com> wrote:
> 
> > > Hmmm...  I wonder if we can do better by making the file position indicate
> > > the key ID rather than being a count of the number of keys read.  It might
> > > make this cleaner.
> > 
> > file position?  as in the result of lseek(fd, 0, SEEK_CUR)?
> > 
> > I don't understand what you're suggesting.
> 
> Currently the file position on /proc/keys indicates the number of keys that
> have been read.  It is incremented by 1 for each key read, irrespective of the
> length of the line that was read for that key.
> 
> We could, instead, map file positions to key IDs, and skip any file positions
> that don't actually map to an extant key.

So you want users to be able to mmap the file and lseek to a particular
spot?  Is that bc you have users with so many keys that
	grep keyid /proc/keys
becomes slow?

Or am I still misunderstanding?

Meanwhile, do you have any objections to these 4 patches?  :)

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/