linux-kernel - Re: [BUGFIX] dm-crypt: Fix a bug of async cryption complete function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49A7D3E5.5040706@redhat.com>
Date:	Fri, 27 Feb 2009 12:52:05 +0100
From:	Milan Broz <mbroz@...hat.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	Huang Ying <ying.huang@...el.com>, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org
Subject: Re: [BUGFIX] dm-crypt: Fix a bug of async cryption complete	function

Herbert Xu wrote:
> On Fri, Feb 27, 2009 at 04:56:11PM +0800, Huang Ying wrote:
>> @@ -830,7 +838,7 @@ static void kcryptd_async_done(struct cr
>>  		return;
>>  	}
>>  
>> -	mempool_free(ablkcipher_request_cast(async_req), cc->req_pool);
>> +	mempool_free(dmreq->req, cc->req_pool);
> 
> Why do we need all this complexity? Can't just fix it by using
> cc->req?

No. There can be parallel req allocated, also cc->req can be NULL.
(seems that these structs are overcomplicated already:-)

(And becuse sometimes the bio request is split into 2 pieces because
of hw restrictions, there can be two ablkcipher_requests for one bio...)

I think that patch is the best what we can do now as bugfix.
(I am just running some tests with that.)

Milan
--
mbroz@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/