linux-kernel - Re: [PATCH] checkpatch: Warn on empty commit log bodies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49A962F8.30609@s5r6.in-berlin.de>
Date:	Sat, 28 Feb 2009 17:14:48 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Mark Brown <broonie@...ena.org.uk>
CC:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies

Mark Brown wrote:
> On Sat, Feb 28, 2009 at 02:58:14PM +0100, Stefan Richter wrote:
> 
>> This gives false positives for patches like this:
> 
>> From: [...]
>> Subject: this single line fully explains the whole patch
> 
>> Signed-off-by: [...]
> 
> That's not a false postive, that's exactly the case it's intended to
> catch.

It *is* a false positive if a single-line changelog is entirely
sufficient.  (There are many patches whose changelogs can and should be
a single line, plus sign-offs.)

You could as well

	if few_changelog_lines
		warn "You have written a short changelog."
		warn "Don't you want to write some more?"
		warn "(PS: I don't care what you write in particular"
		warn "as long as you just add more lines.)"

	if many_changelog_lines
		warn "You have written a long changelog."
		warn "Can't you express yourselves more concisely?"
		warn "(PS: I don't care what you'll omit in particular"
		warn "as long as you get the line count down.)"

> People like Andrew Morton complain because there's no text in
> the actual body of the email (as well as because some of the patches
> that do this could probably use a bit more explanation).

Well, I haven't closely watched akpm's complaints, but I'm sure he
doesn't complain about too few lines changelog, he complains about
insufficient information in the changelog.

Your checkpatch modification does not check for insufficient information
in the changelog.  It only checks line count.
-- 
Stefan Richter
-=====-==--= --=- ===--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/