linux-kernel - Re: [PATCH] checkpatch: Warn on empty commit log bodies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090228164627.GC15127@sirena.org.uk>
Date:	Sat, 28 Feb 2009 16:46:29 +0000
From:	Mark Brown <broonie@...ena.org.uk>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies

On Sat, Feb 28, 2009 at 05:14:48PM +0100, Stefan Richter wrote:
> Mark Brown wrote:

> > That's not a false postive, that's exactly the case it's intended to
> > catch.

> It *is* a false positive if a single-line changelog is entirely
> sufficient.  (There are many patches whose changelogs can and should be
> a single line, plus sign-offs.)

No, really.  People are literally saying that no changelog in the body
of the e-mail is a problem for them.  Since if (like me) you use git
there's nothing in the toolchain that suggests that a changelog might
not have been written it seemed best to add something to generate a
warning.

> > People like Andrew Morton complain because there's no text in
> > the actual body of the email (as well as because some of the patches
> > that do this could probably use a bit more explanation).

> Well, I haven't closely watched akpm's complaints, but I'm sure he
> doesn't complain about too few lines changelog, he complains about
> insufficient information in the changelog.

No, people (not just Andrew) really are complaining about a simple lack
of any text in the body of the mail.  The term "unchangedlogged" has
been specifically used here.  It is apparent that they do not consider
the subject line of the e-mail (which is the first line of the changelog
if you're using git) to be part of the changelog.

> Your checkpatch modification does not check for insufficient information
> in the changelog.  It only checks line count.

Well, yes.  The intention is purely to detect if there is a body in the
changelog.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/