linux-kernel - Re: [PATCH] checkpatch: Warn on empty commit log bodies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49A97563.6040906@s5r6.in-berlin.de>
Date:	Sat, 28 Feb 2009 18:33:23 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Mark Brown <broonie@...ena.org.uk>
CC:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies

Mark Brown wrote:
> It is apparent that they do not consider
> the subject line of the e-mail (which is the first line of the changelog
> if you're using git) to be part of the changelog.

This really surprises me.  ^Subject: .+$ is the title of the log and
thereby its first part.  Also, I don't see a connection to git.  I
manage patches with quilt and never loose patch titles.  I still think
you should count ^Subject: .+$ too if you want to check for presence of
a changelog.

Sometimes I see patch postings with the title appearing twice; I always
thought these were beginners' mistakes and a nuisance when importing a
patch.

(PS:  Granted, many patches come with poorly written changelogs; I
struggle with it in my own patches all the time too.  But it's something
which checkpatch just cannot check.)
-- 
Stefan Richter
-=====-==--= --=- ===--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/