linux-kernel - Re: [PATCH] fix DMI for EFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49AA07DD.1030303@redhat.com>
Date:	Sat, 28 Feb 2009 22:58:21 -0500
From:	Brian Maly <bmaly@...hat.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix DMI for EFI

Thanks. At this point maybe its easier just to move efi_init instead. 
Ill re-work, test and post a followup...

Brian


Yinghai Lu wrote:
> please use git log -p arch/x86/kernel/setup.c to check the history...
>
> YH
>
>
> commit 2216d199b1430d1c0affb1498a9ebdbd9c0de439
> Author: Yinghai Lu <yhlu.kernel@...il.com>
> Date:   Mon Sep 22 02:52:26 2008 -0700
>
>     x86: fix CONFIG_X86_RESERVE_LOW_64K=y
>
>     The bad_bios_dmi_table() quirk never triggered because we do DMI setup
>     too late. Move it a bit earlier.
>
>     Also change the CONFIG_X86_RESERVE_LOW_64K quirk to operate on the e820
>     table directly instead of messing with early reservations - this handles
>     overlaps (which do occur in this low range of RAM) more gracefully.
>
>     Signed-off-by: Ingo Molnar <mingo@...e.hu>
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 161f1b3..d29951c 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -735,7 +735,8 @@ static int __init dmi_low_memory_corruption(const
> struct dmi_system_id *d)
>                 "%s detected: BIOS may corrupt low RAM, working it around.\n",
>                 d->ident);
>
> -       reserve_early_overlap_ok(0x0, 0x10000, "BIOS quirk");
> +       e820_update_range(0, 0x10000, E820_RAM, E820_RESERVED);
> +       sanitize_e820_map(e820.map, ARRAY_SIZE(e820.map), &e820.nr_map);
>
>         return 0;
>  }
> @@ -784,8 +785,6 @@ void __init setup_arch(char **cmdline_p)
>         printk(KERN_INFO "Command line: %s\n", boot_command_line);
>  #endif
>
> -       dmi_check_system(bad_bios_dmi_table);
> -
>         early_cpu_init();
>         early_ioremap_init();
>
> @@ -880,6 +879,10 @@ void __init setup_arch(char **cmdline_p)
>
>         finish_e820_parsing();
>
> +       dmi_scan_machine();
> +
> +       dmi_check_system(bad_bios_dmi_table);
> +
>  #ifdef CONFIG_X86_32
>         probe_roms();
>  #endif
> @@ -967,8 +970,6 @@ void __init setup_arch(char **cmdline_p)
>         vsmp_init();
>  #endif
>
> -       dmi_scan_machine();
> -
>         io_delay_init();
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/