| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <49aa086a.0516300a.50bc.ffff8bae@mx.google.com>
Date: Sat, 28 Feb 2009 23:00:46 -0500
From: <fweisbec@...il.com>
To: unlisted-recipients:; (no To-header on input)
>From 15f92463b7638b978c67674afbe5adfebf8f3958 Mon Sep 17 00: 00:00 2001
In-Reply-To: <20090228091305.GA20533@...e.hu>
References: <20090228091305.GA20533@...e.hu>
From: Frederic Weisbecker <fweisbec@...il.com>
Date: Sun, 1 Mar 2009 04:31:43 +0100
Subject: [PATCH 0/5] Binary ftrace_printk
To: Ingo Molnar <mingo@...e.hu>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Lai Jiangshan <laijs@...fujitsu.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Steven Rostedt <rostedt@...dmis.org>, Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org
An new optimization is making its way to ftrace. Its purpose is to
make ftrace_printk() consuming less memory and become faster.
Written by Lai Jiangshan, the approach is to delay the formatting
job from tracing time to output time.
Currently, a call to ftrace_printk will format the whole string and
insert it into the ring buffer. Then you can read it on /debug/tracing/trace
file.
The new implementation stores the address of the format string and
the binary parameters into the ring buffer, making the packet more compact
and faster to insert.
Later, when the user exports the traces, the format string is retrieved
with the binary parameters and the formatting job is eventually done.
Here is the result of a small comparative benchmark while putting the following
ftrace_printk on the timer interrupt. ftrace_printk is the old implementation,
ftrace_bprintk is a the new one:
ftrace_printk("This is the timer interrupt: %llu", jiffies_64);
After some time running on low load (no X, no really active processes):
ftrace_printk: duration average: 2044 ns, avg of bytes stored per entry: 39
ftrace_bprintk: duration average: 1426 ns, avg of bytes stored per entry: 16
Higher load (started X and launched a cat running on a X console looping on
traces printing):
ftrace_printk: duration average: 8812 ns
ftrace_bprintk: duration average: 2611 ns
Which means the new implementation can be 70 % faster on higher load.
And it consumes lesser memory on the ring buffer.
The three first patches rebase against latest -tip the ftrace_bprintk work done
by Lai few monthes ago.
The two others integrate ftrace_bprintk as a replacement for the old
ftrace_printk implementation and factorize the printf style format decoding
which is now used by three functions.
---
Frederic Weisbecker (2):
tracing/core: drop the old ftrace_printk implementation in favour of
ftrace_bprintk
vsprintf: unify the format decoding layer for its 3 users
Lai Jiangshan (3):
add binary printf
ftrace: infrastructure for supporting binary record
ftrace: add ftrace_bprintk()
include/asm-generic/vmlinux.lds.h | 3 +
include/linux/ftrace.h | 44 ++-
include/linux/module.h | 5 +
include/linux/string.h | 7 +
kernel/module.c | 6 +
kernel/trace/Kconfig | 1 +
kernel/trace/Makefile | 1 +
kernel/trace/trace.c | 139 +++---
kernel/trace/trace.h | 8 +-
kernel/trace/trace_functions_graph.c | 6 +-
kernel/trace/trace_mmiotrace.c | 9 +-
kernel/trace/trace_output.c | 31 +-
kernel/trace/trace_output.h | 2 +
kernel/trace/trace_printk.c | 178 ++++++
lib/Kconfig | 3 +
lib/vsprintf.c | 1006 ++++++++++++++++++++++++++--------
16 files changed, 1127 insertions(+), 322 deletions(-)
create mode 100644 kernel/trace/trace_printk.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists