lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 02 Mar 2009 14:44:28 +0100 From: Jiri Slaby <jirislaby@...il.com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> CC: Dmitry Torokhov <dmitry.torokhov@...il.com>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite On 2.3.2009 14:23, Mark Brown wrote: > index 0000000..b016021 > --- /dev/null > +++ b/drivers/input/touchscreen/zylonite-wm97xx.c [...] > +/* > + * Pressure readback. > + * > + * Set to 1 to read back pen down pressure > + */ > +static int pressure; > +module_param(pressure, int, 1); Weird permissions. > +/* flush AC97 slot 5 FIFO machines */ > +static void wm97xx_acc_pen_up(struct wm97xx *wm) > +{ > + int count = 16; > + schedule_timeout_uninterruptible(1); You meant ssleep(1)? > + > + while (count< 16) { Weird condition. + conding style > + MODR; > + count--; > + } > +} > + > +static int wm97xx_acc_pen_down(struct wm97xx *wm) > +{ > + u16 x, y, p = 0x100 | WM97XX_ADCSEL_PRES; > + int reads = 0; > + > + /* When the AC97 queue has been drained we need to allow time > + * to buffer up samples otherwise we end up spinning polling > + * for samples. The controller can't have a suitably low > + * threashold set to use the notifications it gives. > + */ > + schedule_timeout_uninterruptible(1); ssleep > + if (tries> 5) { Where is tries defined? > +static int wm97xx_acc_startup(struct wm97xx *wm) > +{ > + int idx = 0; No need to initialize. > +static void wm97xx_irq_enable(struct wm97xx *wm, int enable) > +{ > + if (enable) > + enable_irq(wm->pen_irq); > + else > + disable_irq(wm->pen_irq); sync? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists