linux-kernel - Re: [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Mar 2009 14:00:44 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Input: Accelerated touchscreen support for Marvell
	Zylonite

On Mon, Mar 02, 2009 at 02:44:28PM +0100, Jiri Slaby wrote:
> On 2.3.2009 14:23, Mark Brown wrote:

>> +static int pressure;
>> +module_param(pressure, int, 1);

> Weird permissions.

Fixed.

>> +	int count = 16;
>> +	schedule_timeout_uninterruptible(1);

> You meant ssleep(1)?

msleep, but yes.  Shows how old the code is - I'll update.

>> +
>> +	while (count<  16) {

> Weird condition.
> + conding style

Hrm.  This appears to have been mangled somewhere in the mail path to 
you - the indentation is normal in my send-mail folder and in the copy I
got back from the list.


>> +	if (tries>  5) {

> Where is tries defined?

Further up the file as a global static.  I've pulled the variables into
the function since it's the only place they're used.

>> +static int wm97xx_acc_startup(struct wm97xx *wm)
>> +{
>> +	int idx = 0;

> No need to initialize.

Fixed.

>> +static void wm97xx_irq_enable(struct wm97xx *wm, int enable)
>> +{
>> +	if (enable)
>> +		enable_irq(wm->pen_irq);
>> +	else
>> +		disable_irq(wm->pen_irq);

> sync?

Could you expand on this, please?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/