linux-kernel - Re: [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49ABE9F1.9060201@gmail.com>
Date:	Mon, 02 Mar 2009 15:15:13 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Input: Accelerated touchscreen support for Marvell
 Zylonite

On 2.3.2009 15:00, Mark Brown wrote:
> On Mon, Mar 02, 2009 at 02:44:28PM +0100, Jiri Slaby wrote:
>> On 2.3.2009 14:23, Mark Brown wrote:
>>> +	int count = 16;
>>> +	schedule_timeout_uninterruptible(1);
[...]
>>> +	while (count<   16) {
>
>> Weird condition.
>> + conding style
>
> Hrm.  This appears to have been mangled somewhere in the mail path to
> you - the indentation is normal in my send-mail folder and in the copy I
> got back from the list.

OK, anyway the condition looks weird on a semantic layer.

>>> +static void wm97xx_irq_enable(struct wm97xx *wm, int enable)
>>> +{
>>> +	if (enable)
>>> +		enable_irq(wm->pen_irq);
>>> +	else
>>> +		disable_irq(wm->pen_irq);
>
>> sync?
>
> Could you expand on this, please?

No, I was wrong, ignore this one. It's called from within the interrupt 
it disables.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/