linux-kernel - Re: [PATCH] x86, math-emu: fix init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090302195230.GA12252@elte.hu>
Date:	Mon, 2 Mar 2009 20:52:30 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Glöckner <dg@...ix.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	Arjan van de Ven <arjan@...radead.org>
Cc:	x86@...nel.org, Bill Metzenthen <billm@...urbia.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, math-emu: fix init_fpu for task != current


* Daniel Glöckner <dg@...ix.com> wrote:

> init_fpu calls finit to initialize a task's xstate, while finit always
> works on the current task. If we use PTRACE_GETFPREGS on another
> process and both processes did not already use floating point, we get
> a null pointer exception in finit.
> 
> This patch creates a new function finit_task that takes a task_struct
> parameter. finit becomes a wrapper that simply calls finit_task with
> current. On the plus side this avoids many calls to get_current which
> would each resolve to an inline assembler mov instruction.
> 
> Signed-off-by: Daniel Glöckner <dg@...ix.com>
> ---
>  arch/x86/include/asm/i387.h |    1 +
>  arch/x86/kernel/i387.c      |    2 +-
>  arch/x86/math-emu/fpu_aux.c |   31 ++++++++++++++++++++-----------
>  3 files changed, 22 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h
> index 48f0004..10f349b 100644
> --- a/arch/x86/include/asm/i387.h
> +++ b/arch/x86/include/asm/i387.h
> @@ -172,6 +172,7 @@ static inline void __save_init_fpu(struct task_struct *tsk)
> 
>  #else  /* CONFIG_X86_32 */
> 
> +extern void finit_task(struct task_struct *tsk);
>  extern void finit(void);
> 
>  static inline void tolerant_fwait(void)
> diff --git a/arch/x86/kernel/i387.c b/arch/x86/kernel/i387.c
> index b0f61f0..f2f8540 100644
> --- a/arch/x86/kernel/i387.c
> +++ b/arch/x86/kernel/i387.c
> @@ -136,7 +136,7 @@ int init_fpu(struct task_struct *tsk)
>  #ifdef CONFIG_X86_32
>  	if (!HAVE_HWFP) {
>  		memset(tsk->thread.xstate, 0, xstate_size);
> -		finit();
> +		finit_task(tsk);
>  		set_stopped_child_used_math(tsk);
>  		return 0;
>  	}
> diff --git a/arch/x86/math-emu/fpu_aux.c b/arch/x86/math-emu/fpu_aux.c
> index 491e737..aa09870 100644
> --- a/arch/x86/math-emu/fpu_aux.c
> +++ b/arch/x86/math-emu/fpu_aux.c
> @@ -30,20 +30,29 @@ static void fclex(void)
>  }
> 
>  /* Needs to be externally visible */
> -void finit(void)
> +void finit_task(struct task_struct *tsk)

ok, the fix looks good - but we sure want to define this 
function in the "# CONFIG_MATH_EMU is not set" case too, agreed?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/