linux-kernel - Re: [PATCH] x86, math-emu: fix init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Mar 2009 17:01:09 +0100
From:	Daniel Glöckner <dg@...ix.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	"H. Peter Anvin" <hpa@...or.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	Arjan van de Ven <arjan@...radead.org>, x86@...nel.org,
	Bill Metzenthen <billm@...bpc.org.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, math-emu: fix init_fpu for task != current

On 03/02/2009 08:52 PM, Ingo Molnar wrote:
> * Daniel Glöckner <dg@...ix.com> wrote:
[..]
>> This patch creates a new function finit_task that takes a task_struct
>> parameter. finit becomes a wrapper that simply calls finit_task with
>> current. On the plus side this avoids many calls to get_current which
>> would each resolve to an inline assembler mov instruction.
[..]
>> --- a/arch/x86/kernel/i387.c
>> +++ b/arch/x86/kernel/i387.c
>> @@ -136,7 +136,7 @@ int init_fpu(struct task_struct *tsk)
>>  #ifdef CONFIG_X86_32
>>  	if (!HAVE_HWFP) {
>>  		memset(tsk->thread.xstate, 0, xstate_size);
>> -		finit();
>> +		finit_task(tsk);
>>  		set_stopped_child_used_math(tsk);
>>  		return 0;
>>  	}
[..]
> 
> ok, the fix looks good - but we sure want to define this 
> function in the "# CONFIG_MATH_EMU is not set" case too, agreed?

To avoid linker errors if the compiler emits the call although !HAVE_HWFP
is always false? Sounds plausible. I also removed finit from i387.h as the
only other external call site, reg_ld_str.c, gets its prototype from
fpu_proto.h.

Signed-off-by: Daniel Glöckner <dg@...ix.com>
---
 arch/x86/include/asm/i387.h |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h
index 10f349b..71c9e51 100644
--- a/arch/x86/include/asm/i387.h
+++ b/arch/x86/include/asm/i387.h
@@ -172,8 +172,13 @@ static inline void __save_init_fpu(struct task_struct *tsk)

 #else  /* CONFIG_X86_32 */

+#ifdef CONFIG_MATH_EMULATION
 extern void finit_task(struct task_struct *tsk);
-extern void finit(void);
+#else
+static inline void finit_task(struct task_struct *tsk)
+{
+}
+#endif

 static inline void tolerant_fwait(void)
 {
--
1.5.6

-- 
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax -11, Bahnhofsallee 1b, 37081 Göttingen, Germany
Geschäftsführung: Dr. Uwe Kracke, Dr. Cord Seele, Ust-IdNr.: DE 205 198 055
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160

emlix - your embedded linux partner
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/