[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200903021400.50201.david-b@pacbell.net>
Date: Mon, 2 Mar 2009 14:00:49 -0800
From: David Brownell <david-b@...bell.net>
To: Pierre Ossman <drzeus-mmc@...eus.cx>
Cc: Mark Brown <broonie@...ena.org.uk>,
Liam Girdwood <lrg@...mlogic.co.uk>,
lkml <linux-kernel@...r.kernel.org>,
OMAP <linux-omap@...r.kernel.org>
Subject: Re: [patch 2.6.29-rc6+misc] MMC: regulator utilities
On Monday 02 March 2009, Pierre Ossman wrote:
> > > > +int mmc_regulator_set_ocr(struct mmc_host *host, struct regulator *supply)
> > > > +{
> > >
> > > Why not pass the vdd directly? Saves a few dereferences if nothing else.
> >
> > This call syntax is simpler, which is usually a win.
> > Passing a third parameter would create fault paths
> > of the "pass *wrong* parameter" flavor.
> >
> > In terms of object code, when I've looked at such things
> > the dereferences generally cost the same as a ref to a
> > parameter, but passing an extra parameter isn't free.
> >
>
> I couldn't see host being used in there, so I was thinking more of a
> replacement, not an addition.
Oh, I see. That'd make sense. Just pass host->ios.vdd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists