[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20090304092656.fe02dc51.kamezawa.hiroyu@jp.fujitsu.com>
Date: Wed, 4 Mar 2009 09:26:56 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To: Ingo Molnar <mingo@...e.hu>
Cc: linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org,
balbir@...ux.vnet.ibm.com, dhaval@...ux.vnet.ibm.com,
lizf@...fujitsu.cn, menage@...gle.com
Subject: Re: + cgroup-memcg-show-correct-file-mode.patch added to -mm tree
On Tue, 3 Mar 2009 08:58:28 +0100
Ingo Molnar <mingo@...e.hu> wrote:
>
> * akpm@...ux-foundation.org <akpm@...ux-foundation.org> wrote:
>
> > .name = "usage_in_bytes",
> > .private = MEMFILE_PRIVATE(_MEM, RES_USAGE),
> > .read_u64 = mem_cgroup_read,
> > + .mode = 0444
>
> Uhm, we've got symbols for permission bits for a reason.
> (S_IRUGO in this case)
>
> > + .mode = 0444
>
> Ditto.
>
> > + .mode = 0200
>
> Ditto. (S_IWUSR)
>
> > + .mode = 0444
>
> Ditto.
>
ok, will post a replacement.
Thank you for pointing out.
-Kame
> Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists