linux-kernel - Re: + cgroup-allow-subsys-to-set-default-mode-of-its-own-file.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090304092920.cf5fda78.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Wed, 4 Mar 2009 09:29:20 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org,
	balbir@...ux.vnet.ibm.com, dhaval@...ux.vnet.ibm.com,
	lizf@...fujitsu.cn, menage@...gle.com
Subject: Re: + cgroup-allow-subsys-to-set-default-mode-of-its-own-file.patch
 added to -mm tree

On Tue, 3 Mar 2009 08:59:00 +0100
Ingo Molnar <mingo@...e.hu> wrote:

> 
> * akpm@...ux-foundation.org <akpm@...ux-foundation.org> wrote:
> 
> > +		int mode = 0644;
> > +		if (cft->mode)
> > +			mode = cft->mode;
> 
> ditto...
> 
Maybe Li Zefan's one "cgroups-show-correct-file-mode.patch" is now in -mm.
and this patch is dropped. And it has the same problem...

Li-san, could you rewrite this part of your patch
==
+	if (cft->read || cft->read_u64 || cft->read_s64 ||
+	    cft->read_map || cft->read_seq_string)
+		mode |= 0444;
+
+	if (cft->write || cft->write_u64 || cft->write_s64 ||
+	    cft->write_string || cft->trigger)
+		mode |= 0200;
+
==
with macro as S_IRUSR etc... ?

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/