linux-kernel - Re: [PATCH] x86: make text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090305103852.GD32407@elte.hu>
Date:	Thu, 5 Mar 2009 11:38:52 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Masami Hiramatsu <mhiramat@...hat.com>
Cc:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nick Piggin <npiggin@...e.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"H. Peter Anvin" <hpa@...or.com>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH] x86: make text_poke() atomic using fixmap


* Masami Hiramatsu <mhiramat@...hat.com> wrote:

> Hi Ingo,
> 
> Here is the patch which uses fixmaps instead of vmap in 
> text_poke(). This made the code much simpler than I thought 
> :).

Looks good to me at a quick glance albeit Linus had second 
thoughts about using fixmaps for this in the past. But with 
delayed-flush for vmaps i think fixmaps are again the simpler 
and more robust - albeit more limited - choice ...

In any case, the x86 tree already unified fixmap.h so could you 
please resend the whole series as a 0/3, 1/3, 2/3, 3/3 thing 
against tip:master, starting a new thread on lkml? (this thread 
is already way too deep)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/