linux-kernel - Re: commit "radeonfb: Fix resume from D3Cold on some platforms" breaks resume from RAM on PowerBook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090305125919.GA5474@soziologie.ch>
Date:	Thu, 5 Mar 2009 13:59:19 +0100
From:	Gaudenz Steinlin <gaudenz@...iologie.ch>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: commit "radeonfb: Fix resume from D3Cold on some platforms"
	breaks resume from RAM on PowerBook

On Thu, Mar 05, 2009 at 01:25:20PM +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2009-03-04 at 09:38 +0100, Gaudenz Steinlin wrote:
> > Hi Benjamin
> > 
> > The commit 1fb25cb8b83e85f5bf1a4adb3c9a254c4ce92405 "radeonfb: Fix resume 
> > from D3Cold on some platforms" breaks resume from suspend to RAM on my
> > PowerBook (Model PowerBook5,8 with ATI Mobility Radeon 9600 M10).
> > 
> > On resume the pulsing led indicating sleep just changes to solid white
> > and nothing else happens. 
> > 
> > Reverting this commit on top of the current Linus' tree fixes resume.
> 
> Ok, so after some tests here on what appear to the the exact same
> machine...
> 
> I did the commit specifically to -fix- a regression due to upstream
> changes, ie, for me it doesn't work without that commit. That is very
> weird.
> 
> In fact, I just tried also with AGP and DRM enabled with X wobbly
> windows etc... and it's working just fine.
> 
> I know that the early resume hack I have in there for powerbooks might
> be a bit fishy, so please try without it (according to my previous email
> on that matter).
> 
> Please let me know if that makes a difference.

As already said in an earlier mail, this does not make any difference. I
now ran some more tests:

-> with ppc32_defconfig: same results, resume with your commit is
   broken, I did not yet test if reverting the commit fixes resume.
   Please tell me if you are interested in this result.
-> with a minimal config (attached): resume does not work at all with or 
   without your commit. I suspect this is another bug with the same
   symptoms. 

If you have any ideas, I would be happy to do further tests. I could
also send you my compiles kernel (as a Debian package or a tar file) or
you could send me your working kernel image to see if it also works for
me. 

Gaudenz

-- 
Ever tried. Ever failed. No matter.
Try again. Fail again. Fail better.
~ Samuel Beckett ~

View attachment "config-2.6.29-rc7-bisect" of type "text/plain" (34847 bytes)